Refactor SDK metrics: rename metrics from cloud_provider_stackit_http* to stackit_api_http.* - #1516
Refactor SDK metrics: rename metrics from cloud_provider_stackit_http* to stackit_api_http.*#1516ske-prow[bot] merged 3 commits into
Conversation
Sorry, something went wrong.
|
/cherry-pick release-v1.34 |
Sorry, something went wrong.
|
@dergeberl: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sorry, something went wrong.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breuerfelix The full list of commands accepted by this bot can be found here. The pull request process is described here Details Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment |
Sorry, something went wrong.
|
LGTM label has been added. DetailsGit tree hash: e66824f2ebad700d8fbd00348c642b6e4221670d |
Sorry, something went wrong.
|
@dergeberl: new pull request created: #1531 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sorry, something went wrong.
|
@dergeberl: new pull request created: #1532 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sorry, something went wrong.
|
@dergeberl: new pull request created: #1533 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sorry, something went wrong.
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
This PR will change the metrics from cloud_provider_stackit_http.* to stackit_api_http.*.
The metrics do not contain an API label anymore which needed to be configured. They now contain the host of the API which contains the same information. Also the op labe was renamed to operation label and now contains the function name from the SDK. It also contains a component which can be different within the same repo, like cloud-controller-manager and stackit-csi-plugin.
The metrics package can be used the same way also in other repos later like application-load-balancer-controller.
Special notes for your reviewer:
Breaking changes:
/label breaking
Rename of metrics cloud_provider_stackit_http.* to stackit_api_http.*.
Different labels on the metrics (host instead of api and operation instead of op)