This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Stackless issue #275: Support PEP-523 eval_frame-hook - #276
Merged
akruis merged 12 commits intoAug 8, 2021
Merged
Conversation
Integrate the C-function PyEval_EvalFrameEx_slp into into the C-function slp_eval_frame_value and rename slp_eval_frame_value to PyEval_EvalFrameEx_slp. Adapt the gdb support library and document the change.
Support the PEP-523 eval_frame-hook for one particular use case: byte code instrumentation. An example is the pydev-debugger. It can use the hook to inject "break-points". This is much more efficient, than traditional trace functions.
Support the PEP-523 eval_frame-hook for one particular use case: byte code instrumentation. An example is the pydev-debugger. It can use the hook to inject "break-points". This is much more efficient, than traditional trace functions. Improve the implementation and add a test case.
Update changelog.txt
This was referenced Jun 22, 2021
akruis
marked this pull request as ready for review
July 16, 2021 17:59
Copy link
Copy Markdown
Author
|
Now that upstream commit bdace21 has been merged (commit 05f4c34 in branch 3.8-slp) Stackless 3.8 is ABI compatible with Cython for C-Python 3.8. Therefore I could test the latest PyDev Debugger and it works well. I used gdb to verify that the eval_frame_hook is indeed used as expected. Time to merge the pull request and to port it to main-slp. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stackless issue #275: Support PEP-523 eval_frame-hook
Support the PEP-523 eval_frame-hook for one particular use case: byte
code instrumentation. An example is the pydev-debugger. It can use the
hook to inject "break-points". This is much more efficient, than
traditional trace functions.
Tested with eclipse pydev 8.3.0.202104101217 and with the current 'main' branch of https://github.com/fabioz/PyDev.Debugger. It works, and does not crash, but it does not modify byte code, because Stackless main-slp does not yet support PEP-570.
Support for PEP-570 comes between v3.8.0a3 and v3.8.0a4 with commit 8c77b8c. Therefore we should delay this pull request until after merging 8c77b8c. We need additional commits, at least bdace21.