FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for macOS and allow building stacks-core from commit hash by radu-stacks · Pull Request #39 · stacks-network/hacknet · GitHub

/ hacknet Public

Add support for macOS and allow building stacks-core from commit hash - #39

Merged
simone-stacks merged 22 commits into
stacks-network:masterfrom
radu-stacks:feat/mac-os-support
Jun 17, 2026
ConversationCommits (22)ChecksFiles changed
Merged

Add support for macOS and allow building stacks-core from commit hash#39
simone-stacks merged 22 commits into
stacks-network:masterfrom
radu-stacks:feat/mac-os-support

Conversation

radu-stacks commented May 12, 2026

Copy link
Copy Markdown
Contributor

Continuation of #29 which became stale.

radu-stacks requested a review from wileyj May 12, 2026 10:28

CLAassistant commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

radu-stacks changed the title This PR adds support for macOS and allows building stacks-core from commit hash Add support for macOS and allows building stacks-core from commit hash May 12, 2026
ASuciuX and others added 3 commits May 12, 2026 13:34
radu-stacks force-pushed the feat/mac-os-support branch from 207ea2f to b78fbfb Compare May 12, 2026 10:34

radu-stacks commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

radu-stacks mentioned this pull request May 12, 2026
Closed
radu-stacks changed the title Add support for macOS and allows building stacks-core from commit hash Add support for macOS and allow building stacks-core from commit hash May 12, 2026
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread docker/stacks/Dockerfile
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread docker/docker-compose.yml Outdated
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile Outdated
wileyj reviewed May 12, 2026
View reviewed changes
Comment thread Makefile Outdated

wileyj commented May 12, 2026

Copy link
Copy Markdown
Contributor

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

i see @ASuciuX is credited as co-author so it's perfectly fine

wileyj mentioned this pull request May 21, 2026
Merged
radu-stacks requested a review from wileyj May 24, 2026 19:22
wileyj approved these changes May 26, 2026
View reviewed changes

wileyj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

radu-stacks commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@wileyj Seems we cannot merge because you are the last pusher and the reviewer (and I cannot approve and merge my own PR). Will have to commit something so your approval counts as a valid one.

radu-stacks requested a review from wileyj May 27, 2026 10:41
wileyj approved these changes May 27, 2026
View reviewed changes

wileyj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

adriano-stacks previously approved these changes May 28, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
Comment thread docker/stacks/Dockerfile Outdated
Revert "Pin latest actions/checkout v6.0.2"
ba369e7 
This reverts commit cab2e7e. Switching
back to repo-level whitelisted action commit SHA.
Fix hacknet-liveness.sh checks
2572c6f
simone-stacks reviewed Jun 15, 2026
View reviewed changes
Comment thread Makefile Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread docker/stacks/Dockerfile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
simone-stacks approved these changes Jun 17, 2026
View reviewed changes

simone-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

simone-stacks merged commit 1d74a1f into stacks-network:master Jun 17, 2026
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

simone-stacks simone-stacks approved these changes
adriano-stacks Awaiting requested review from adriano-stacks
+1 more reviewer
wileyj wileyj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL