FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert reports to JSON by oliversalzburg · Pull Request #135 · stacktracejs/stacktrace.js · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .js  (6) .json  (1) .map  (2) dotfile  (2) All 4 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions .jshintignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist/*
3 changes: 2 additions & 1 deletion .jshintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"JASMINE": true,
"JASMINE_ADAPTER": true,
"matchers": true,
"priv": true
"priv": true,
"JSON": true
}
}
4 changes: 2 additions & 2 deletions dist/stacktrace-with-polyfills.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace-with-polyfills.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
};
req.open('post', url);
req.setRequestHeader('Content-Type', 'application/json');
req.send({stack: stackframes});
req.send(JSON.stringify({stack: stackframes}));
});
}
};
Expand Down
2 changes: 1 addition & 1 deletion dist/stacktrace.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace.min.js.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions gulpfile.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ var uglify = require('gulp-uglify');

var polyfills = [
'./node_modules/es6-promise/dist/es6-promise.js',
'./node_modules/json3/lib/json3.js',
'./polyfills.js'
];
var dependencies = [
Expand Down
1 change: 1 addition & 0 deletions package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"gulp-uglify": "^1.4.1",
"jasmine-node": "~1.14",
"jasmine-sinon": "^0.4.0",
"json3": "^3.3.2",
"karma": "^0.13.9",
"karma-chrome-launcher": "^0.2.0",
"karma-coverage": "^0.5.2",
Expand Down
3 changes: 2 additions & 1 deletion spec/stacktrace-spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ describe('StackTrace', function () {
});
waits(100);
runs(function () {
expect(server.requests[0].requestBody).toEqual({stack: stackframes});
var expectedResponse = JSON.stringify({stack: stackframes});
expect(server.requests[0].requestBody).toEqual(expectedResponse);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Line is too long.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How can that still be too long? O_o

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hm.. I'm guessing the default line length limit is 80.

Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.

expect(server.requests[0].url).toEqual(url);
expect(callback).toHaveBeenCalledWith('OK');
expect(errback).not.toHaveBeenCalled();
Expand Down
2 changes: 1 addition & 1 deletion stacktrace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
};
req.open('post', url);
req.setRequestHeader('Content-Type', 'application/json');
req.send({stack: stackframes});
req.send(JSON.stringify({stack: stackframes}));
});
}
};
Expand Down

Back | FazBrowse Home | New Git URL