FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Consistently use 'long int' for return of size functions by WardBrian · Pull Request #3086 · stan-dev/math · GitHub

/ math Public

Consistently use 'long int' for return of size functions - #3086

Merged
WardBrian merged 7 commits into
developfrom
fix/3085-use-long-int-for-container-sizes
Jun 18, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Consistently use 'long int' for return of size functions#3086
WardBrian merged 7 commits into
developfrom
fix/3085-use-long-int-for-container-sizes

Conversation

WardBrian commented Jun 17, 2024

Copy link
Copy Markdown
Member

Summary

Closes #3085

Tests

Side Effects

I certainly hope we weren't relying on something like these having wrapping semantics.

Release notes

Functions concerned with the number of entries in a container (size, cols, rows, ...) consistently use long int as their return type.

Checklist

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

andrjohns commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator

This should probably be int64_t instead of long int, since (naturally) a long int on Windows is only 32-bit

SteveBronder previously approved these changes Jun 18, 2024
View reviewed changes

SteveBronder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Once tests pass this looks good to me

WardBrian requested a review from SteveBronder June 18, 2024 20:57

stan-buildbot commented Jun 18, 2024

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.32 0.33 0.98 -2.18% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.03 2.86% faster
gp_regr/gen_gp_data.stan 0.02 0.02 1.04 4.14% faster
gp_regr/gp_regr.stan 0.1 0.1 1.04 3.47% faster
sir/sir.stan 73.37 77.69 0.94 -5.88% slower
irt_2pl/irt_2pl.stan 4.15 4.37 0.95 -5.22% slower
eight_schools/eight_schools.stan 0.06 0.06 0.99 -1.04% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.27 0.98 -2.4% slower
pkpd/one_comp_mm_elim_abs.stan 20.49 20.34 1.01 0.73% faster
garch/garch.stan 0.46 0.46 0.99 -0.54% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.86 2.83 1.01 1.08% faster
arK/arK.stan 1.99 1.88 1.06 5.55% faster
gp_pois_regr/gp_pois_regr.stan 3.11 2.98 1.05 4.34% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.73 8.95 1.09 8.01% faster
performance.compilation 180.29 187.83 0.96 -4.18% slower
Mean result: 1.0074829516270551

Jenkins Console Log
Blue Ocean
Commit hash: 77554050a1a21ca0cd75a51634da497a3174a1aa

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 3700.001
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian merged commit 4c626fd into develop Jun 18, 2024
WardBrian deleted the fix/3085-use-long-int-for-container-sizes branch August 5, 2024 00:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SteveBronder SteveBronder approved these changes
andrjohns Awaiting requested review from andrjohns

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent type used for size of containers

4 participants

Back | FazBrowse Home | New Git URL