| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@WardBrian Thanks for taking care of this. @SteveBronder, I feel like you're more familiar with the code at this point and can do this review more expeditiously, but let me know if you don't have the time and need me to jump in. |
Sorry, something went wrong.
[ci skip]
|
Merged in the changes from #3213 @SteveBronder |
Sorry, something went wrong.
|
@SteveBronder mind looking at stan-dev/stanc3#1521? It needs to be merged at the same time as this |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Discussed in #3202 (comment), counterpart to stan-dev/stanc3#1521
Summary
Theta0 is now a tolerance parameter rather than required. When not provided, we assume a vector of 0s is sufficient.
This required a bit of re-organization to get the size right, but otherwise wasn't too bad because we call the covariance function pretty early and can get the size from the return of that function.
Tests
Existing tests updated
Side Effects
Release notes
Checklist
Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested