| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
4607907 should probably lead to a STAN_CHANGES file like we do for tbb, just for documentation: https://github.com/stan-dev/math/blob/develop/lib/tbb_2020.3/STAN_CHANGES |
Sorry, something went wrong.
|
Yes. Also I tried to rebase / squash some commits right before I pushed and that has made a few tests break. But I can fix that stuff and repush. |
Sorry, something went wrong.
|
@WardBrian can you run the fft test that is failing on your local windows machine? That test passes on linux for me. |
Sorry, something went wrong.
|
@SteveBronder it passed on my local Windows machine but note that I am not using an ARM chip |
Sorry, something went wrong.
|
This is now passing the math pipeline! (Thanks @SteveBronder) There is a failure downstream in stan: In file included from ./src/stan/model/indexing/rvalue_varmat.hpp:7,
from <command-line>:
src/stan/model/indexing/rvalue.hpp: In lambda function:
src/stan/model/indexing/rvalue.hpp:283:29: error: 'all' is not a member of 'Eigen'
I think this is an easy one by comparison... |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
|
@SteveBronder I think this is really close, just a failure in the distribution tests: In file included from test/prob/bernoulli/bernoulli_cdf_log_00000_generated_ffv_test.cpp:3:
In file included from ./test/prob/test_fixture_distr.hpp:4:
In file included from ./stan/math/mix.hpp:8:
In file included from ./stan/math/mix/meta.hpp:6:
In file included from ./stan/math/rev/core.hpp:32:
In file included from ./stan/math/rev/core/operator_divide_equal.hpp:5:
In file included from ./stan/math/rev/core/operator_division.hpp:15:
In file included from ./stan/math/rev/fun/to_arena.hpp:7:
In file included from ./stan/math/prim/functor.hpp:25:
In file included from ./stan/math/prim/functor/map_rect_combine.hpp:7:
In file included from ./stan/math/prim/functor/operands_and_partials.hpp:7:
./stan/math/prim/functor/broadcast_array.hpp:34:19: error: call to function 'sum' that is neither visible in the template definition nor found by argument-dependent lookup
prim_.get() = sum(m);
|
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
|
Looks like tests passed @SteveBronder! Do you mind rewriting the history of the commits a bit and adding a STAN_CHANGES to the Eigen folder? |
Sorry, something went wrong.
|
All the Stan math changes are now in cd15587 |
Sorry, something went wrong.
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
|
I'll try to work through cd15587 tomorrow. Any news on if eigen Upstream accepted the patches for the intrinsics and memset issue? |
Sorry, something went wrong.
|
They accepted the patches but are not going to push a new release yet. But RcppEigen did take in the patches so we are good on the R side of things |
Sorry, something went wrong.
There was a problem hiding this comment.
Skimmed the stan changes, most look good as simple header cleanups or forwarding changes. A few things besides the two conflicts that have arisen
Sorry, something went wrong.
# Conflicts: # stan/math/mix/functor/conditional_copy_and_promote.hpp # stan/math/mix/functor/laplace_likelihood.hpp # stan/math/mix/functor/laplace_marginal_density.hpp # stan/math/prim/functor/conditional_copy_and_promote.hpp # stan/math/rev/functor/conditional_copy_and_promote.hpp
Jenkins Console Log Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: G++: Clang: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
This moves Stan math up to Eigen 5.0.1. I broke this up by commit so that the changes would be more legible
14cbe65 removes the old Eigen
3d74c35 adds new eigen
4607907 adds the patch as discussed in RcppCore/RcppEigen#143 (comment)
7164bb2 for stan specific changes
The biggest stan changes are the we have to use val_op() instead of plain val() more often. Then we had some type deduction issues with mdivide_lower_tri. Besides that it was not too bad!
Note that this is just for Stan Math, I still need to run all of the tests with the stan repo. I'm guessing we will have some issues up there since we use a few weird views
Tests
No new tests
Release notes
Update to Eigen 5.0.1
Checklist
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested