| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Awesome. I'll get it merged into the other branch today. |
Sorry, something went wrong.
|
@SteveBronder, I just made types explicit and I'm merging it.
This isn't correct. Although the functions are templated to be generic, the internal function can't be called under all uses of autodiff types. I had the same thought originally, but after working through the code, the code paths that use fvar don't go through the internal functions. I left the names as you wrote them. |
Sorry, something went wrong.
|
(If there are problems on the original branch and testing due to my mistakes, I'll figure out how to correct it on the other PR.) |
Sorry, something went wrong.
|
With this merged can we close out the other gamma lccdf pr? |
Sorry, something went wrong.
|
@spinkney this was merged into that other branch, not into develop |
Sorry, something went wrong.
|
Ah ok, so is that other pr good to be merged now? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Checklist
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested