FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix/gamma lccdf v3 review by SteveBronder · Pull Request #3296 · stan-dev/math · GitHub

/ math Public

Fix/gamma lccdf v3 review - #3296

Merged
syclik merged 4 commits into
fix-gamma-lccdf-v3from
fix/gamma-lccdf-v3-review
Mar 17, 2026
Merged

Fix/gamma lccdf v3 review#3296
syclik merged 4 commits into
fix-gamma-lccdf-v3from
fix/gamma-lccdf-v3-review

Conversation

Copy link
Copy Markdown
Collaborator

Summary

value_of and value_of_ref fixes

Tests

python3 ./runTests.py -j6 ./test/prob/gamma/
python3 ./runTests.py -j6 --run-all ./test/unit/ -f gamma_lcc 

Side Effects

Are there any side effects that we should be aware of?

Release notes

Replace this text with a short note on what will change if this pull request is merged in which case this will be included in the release notes.

Checklist

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

SteveBronder requested a review from syclik March 16, 2026 21:15
SteveBronder mentioned this pull request Mar 16, 2026
4 tasks

syclik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome!

syclik merged commit 7724011 into fix-gamma-lccdf-v3 Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL