FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

20/isin array by chaburkland · Pull Request #34 · static-frame/arraykit · GitHub

/ arraykit Public

20/isin array - #34

Open
chaburkland wants to merge 32 commits into
static-frame:masterfrom
chaburkland:20/isin_array
ConversationCommits (32)ChecksFiles changed
Open

20/isin array#34
chaburkland wants to merge 32 commits into
static-frame:masterfrom
chaburkland:20/isin_array

Conversation

chaburkland commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes #20

Checklist

  • Object 1D
  • Object 2D
  • Dtype 1D unique
  • Dtype 2D unique
  • Dtype 1D non-unique
  • Dtype 2D non-unique

chaburkland self-assigned this Mar 10, 2021
chaburkland added 21 commits March 9, 2021 21:37
Lints.
a0aa83e
Lints.
01e0496
Adds a more explicit failure message.
329258d
Adds more info to debug msg.
64286d9
Adds test for failing windows.
2cb35fd
Adds initial support for object dtypes.
996b47a
Cleans up ref counts and error handling in AK_isin_array_object.
b546e34
Adds AK_GOTO_ON_NOT. Cleans up variable names. Handles refcounts & er…
71d2fa2 
…rors in AK_isin_array_dtype
Partial commit to save work. Working on infrastructure for non-unique…
6c07d65 
… dtype arrays.
Fixes compiler warnings & rearranges order of function declarations
376c49a
Completes initial pass to have compiling code. Not working yet.
d306991
Fixes some reference count issues, type inconsistencies, and adds a b…
38eaeb7 
…ranch I forgot about.
Adds an alternative method to simply use numpy :(
ac476ad
Adds a lot more performance testing infrastructure.
d3b818c
Finishes perf setup.
e6b1c85
Adds work for missing trailing False for non-unique arrays.
52c029c
Finishes debug testing on 2D non-unique branch.
904cdf6
Lints.
886ec4a
Updates macro to support previous Python versions.
db5bf34
Cleans up a lot of duplicate code.
4aafd21
Fixes some c-compiler warnings I think?
29a4ec7
brandtbucher requested changes Mar 15, 2021
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh boy. 🙂

I just went over this quickly during lunch. I've refrained from checking or commenting on anything except refcounts, to keep this focused.

I may have missed or falsely flagged some since I went through this so quickly. But I'm confident most of them are genuine leaks.

Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated
Comment thread arraykit.c Outdated

chaburkland commented Mar 15, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks @brandtbucher . These comments make me realize that my understanding of Python's object reference management is virtually non-existent. I'm thinking that it would be really helpful to meet with you to talk about it since I want to understand the core design of it, so that I can intuit where (and why) these leaks are happening myself

brandtbucher reviewed Mar 18, 2021
View reviewed changes
Comment thread arraykit.c Outdated
Update arraykit.c
b161f01 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
chaburkland marked this pull request as ready for review March 26, 2021 21:49
brandtbucher removed their request for review November 17, 2022 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher requested changes

Assignees

chaburkland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement isin_array

2 participants

Back | FazBrowse Home | New Git URL