test: migrate math/base/special/erfcinv to ULP-based testing - #13761
Merged
kgryte merged 1 commit intoJul 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sorry, something went wrong.
kgryte
approved these changes
Jul 30, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request migrates the tests for @stdlib/math/base/special/erfcinv (test/test.js and test/test.native.js) from relative-tolerance (EPS-scaled delta/tol) comparisons to ULP-difference assertions using @stdlib/assert/is-almost-same-value.
The seven fixture blocks each had a distinct tolerance multiplier in the original tests (3.0, 3.0, 3.0, 13.0, 14.0, 9.0, and 1.0 times EPS). Final ULP constants were determined empirically by computing the actual maximum ULP distance between the JS implementation's output and the Julia fixture data for each block, then confirming that the tests fail at N - 1 and pass deterministically (verified across two consecutive runs) at the chosen N:
The native add-on could not be built in this environment, so test.native.js assertions are skipped, but the file was updated identically to test.js (native add-on is expected to produce the same output as the JS implementation).
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
Generated by Claude Code