| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…ertions Replaces EPS-scaled relative tolerance comparisons (and, in the native test, `toFixed( 4 )` string comparisons) with `isAlmostSameValue` assertions. Over the full 500-value Julia fixture set, both the JavaScript and native implementations reproduce the expected values bit-for-bit, so the tightest passing bound is 0 ULP. Ref: #11352 Claude-Session: https://claude.ai/code/session_01PjUefgKYy3gQjkssALyEzH
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sorry, something went wrong.
|
⚠️ Issue Reference Review An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Ref #11352.
Description
This pull request:
Final ULP bound: 0 in both test/test.js and test/test.native.js.
Measured minimum: starting from a high bound and tightening, the minimum integer bound which passes over the full fixture set is 0, i.e. both implementations reproduce every fixture value bit-for-bit. Over all 500 Julia fixture values, the maximum ULP difference is 0 for the JavaScript implementation and 0 for the native implementation (the native add-on was built locally so that test/test.native.js actually executed rather than being skipped). The full suite (1018 assertions across both test files) was run twice at the final bound with identical results, so no FMA/arch-related nondeterminism was observed on this platform (Linux x86-64, gcc).
This is expected: the JavaScript and C implementations evaluate the identical expression ( (a*a) + (b*b) + (c*c) - (a*b) - (a*c) - (b*c) ) / 18.0, so absent FMA contraction the two agree exactly with the reference values.
Only the two test files are modified; no source, documentation, benchmark, or fixture files are touched.
Related Issues
This pull request has the following related issues:
Questions
Other
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which selected the package, mirrored the conversion idiom used in previously converted packages, measured the ULP bound against the fixture set, and verified tests and linting.
@stdlib-js/reviewers
Generated by Claude Code