| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…rtions Replace the relative tolerance assertions in the fixture loops of `test/test.js` and `test/test.native.js` with `isAlmostSameValue` ULP difference assertions. The ULP bound was tightened to the measured minimum of 369 for both the JavaScript and C implementations. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gUyuE14QfhKCjNXJ7RSJj
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Resolves a part of #11352.
Description
This pull request:
Specifically, in both test/test.js and test/test.native.js, the fixture loop previously branched on exact equality and otherwise compared a computed delta against a computed tol (320.0 * EPS * abs( expected[ i ] )). That branch is replaced with a single
assertion, @stdlib/assert/is-almost-same-value is added as a dependency of the tests, and the now unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires (along with the delta and tol locals) are removed.
ULP bound: 369 (both test/test.js and test/test.native.js).
The bound was tightened empirically. Measuring ulpdiff( y, expected[ i ] ) over the full 100-case Python fixture set yields a maximum ULP difference of 369, attained at alpha = 19.971069118488785, beta = 18.29265599414557. Sweeping the bound upwards from 0 confirms 369 is the minimum admissible value: running the suite at 368 fails exactly that one case, while 369 passes all of them. The JavaScript and C implementations were measured independently and both require the same bound of 369.
Verification:
Only the two test files are changed; no source, fixture, benchmark, or documentation files were touched.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
The editorconfig pre-commit hook could not run in this environment because it attempts to download the editorconfig-checker binary from GitHub releases, which is not reachable here. The two changed files were instead checked manually for the relevant .editorconfig rules (LF line endings, UTF-8, tab indentation, no trailing whitespace, final newline).
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. Claude selected the package, mirrored the conversion idiom from previously merged ULP migration commits, measured the minimum ULP bound against the fixture set, and ran the tests and test linter locally.
@stdlib-js/reviewers
Generated by Claude Code