FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Provides "#" string evaluation support for JSON Pointer by erosb · Pull Request #292 · stleary/JSON-java · GitHub

Provides "#" string evaluation support for JSON Pointer - #292

Merged
stleary merged 1 commit into
stleary:masterfrom
erosb:master
Oct 8, 2016
Merged

Provides "#" string evaluation support for JSON Pointer#292
stleary merged 1 commit into
stleary:masterfrom
erosb:master

Conversation

erosb commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

No description provided.

stleary commented Oct 6, 2016
edited
Loading

Copy link
Copy Markdown
Owner

What problem does this code solve?
In the JSON Pointer spec, "#" and "" are equivalent strings

Risks
Low. This adds required functionality to an ancillary JSON-Java feature. While existing apps may erroneously depend on the existing behavior, this is still a relatively new feature.

Changes to the API?
No.

Will this require a new release?
May be rolled into the next release.

Should the documentation be updated?
No.

Does it break the unit tests?
No, but a new unit test is added to exercise this code change.

Review status
ACCEPT. Starting 3 day comment window with this post.

stleary changed the title fixing #291 Provides "#" pointer string evaluation support for JSON Pointer Oct 6, 2016
stleary changed the title Provides "#" pointer string evaluation support for JSON Pointer Provides "#" string evaluation support for JSON Pointer Oct 6, 2016
stleary merged commit 237376e into stleary:master Oct 8, 2016
stleary added a commit to stleary/JSON-Java-unit-test that referenced this pull request Oct 8, 2016
erosb added a commit to everit-org/json-schema that referenced this pull request May 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL