FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

JSON parsing self reference object and array by sk02241994 · Pull Request #823 · stleary/JSON-java · GitHub

/ JSON-java Public

JSON parsing self reference object and array - #823

Merged
stleary merged 5 commits into
stleary:masterfrom
sk02241994:issue_743
Dec 27, 2023
ConversationCommits (5)ChecksFiles changed
Merged

JSON parsing self reference object and array#823
stleary merged 5 commits into
stleary:masterfrom
sk02241994:issue_743

Conversation

sk02241994 commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Fix for issue #743
Self reference issue found in JSONObject and JSONArray

stleary commented Nov 27, 2023

Copy link
Copy Markdown
Owner

@sk02241994 Out of sync, please merge master to your branch.

sk02241994 commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

@stleary master is merged to my branch.

stleary reviewed Nov 28, 2023
View reviewed changes
Comment thread src/main/java/org/json/JSONObject.java Outdated
stleary changed the title JSON parsion self reference object and array JSON parsing self reference object and array Dec 9, 2023
stleary mentioned this pull request Dec 9, 2023
Closed
stleary reviewed Dec 22, 2023
View reviewed changes
Comment thread src/test/java/org/json/junit/JSONObjectTest.java Outdated
stleary reviewed Dec 22, 2023
View reviewed changes
Comment thread src/test/java/org/json/junit/JSONArrayTest.java Outdated
stleary reviewed Dec 22, 2023
View reviewed changes
Comment thread src/test/java/org/json/junit/JSONArrayTest.java Outdated
stleary reviewed Dec 22, 2023
View reviewed changes
Comment thread src/test/java/org/json/junit/JSONArrayTest.java Outdated
stleary reviewed Dec 22, 2023
View reviewed changes
Comment thread src/test/java/org/json/junit/JSONArrayTest.java Outdated

stleary commented Dec 22, 2023

Copy link
Copy Markdown
Owner

@sk02241994 For now, we just want JSONParserConfiguration to act as a marker class. All of the required functionality is already in the base class ParserConfiguration, so you can leverage that. Future commits will add more config properties.
Will go through the changes to JSONObject and JSONArray later.

stleary reviewed Dec 23, 2023
View reviewed changes
Comment thread src/main/java/org/json/JSONArray.java Outdated
* @param value
* The Map value.
* @param jsonParserConfiguration
* Configuration for recursive depth

stleary Dec 23, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please just call this a configuration object. The things that it can configure will change going forward

stleary reviewed Dec 23, 2023
View reviewed changes
Comment thread src/main/java/org/json/JSONArray.java Outdated
*
* @param recursionDepth
* Variable to keep the count of how nested the object creation is happening.
* @param recursionDepth

stleary Dec 23, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please change to jsonParserConfiguration

stleary reviewed Dec 23, 2023
View reviewed changes
Comment thread src/main/java/org/json/JSONObject.java Outdated

stleary commented Dec 23, 2023

Copy link
Copy Markdown
Owner

@sk02241994 Looks good, couple remaining items to clean up, nothing functional though.

stleary commented Dec 24, 2023

Copy link
Copy Markdown
Owner

What problem does this code solve?
Fixes potential stackoverflow errors due to exceeding maximum nesting depth

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No, some new API methods were added

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. Also, new unit tests were added.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

stleary merged commit d7819a4 into stleary:master Dec 27, 2023
sk02241994 deleted the issue_743 branch December 29, 2023 14:06
stleary mentioned this pull request Jan 1, 2024
Closed
This was referenced Oct 5, 2024
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stleary stleary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL