Refactoring: Remove unused method from jsonobject - #988
Merged
stleary merged 1 commit intoJun 16, 2025
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
javadev
approved these changes
Jun 16, 2025
Copy link
Copy Markdown
Owner
Author
|
Thanks @javadev, somehow I forgot about this PR due to family travel. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
A previous commit included a change to this code, but a later check showed the method is not used, so it is removed here.
Does the code still compile with Java6?
Yes
Risks
Low
Changes to the API?
No, it was a private method
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No
Was any code refactored in this commit?
This commit was a refactor
Review status
APPROVED - by myself
Starting 3-day comment window