Fixed included headers - #121
Merged
fpistm merged 1 commit intoOct 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
fpistm
force-pushed
the
Cleaned_include
branch
from
d25f5bd to
01b4534
Compare
October 4, 2017 09:26
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
fpistm
force-pushed
the
Cleaned_include
branch
from
01b4534 to
90d3863
Compare
October 4, 2017 12:32
ghost
reviewed
Oct 5, 2017
ghost
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Is there a risk with the libraries currently available? Should we test them?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've tested some of them without any issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
I will remove the variant.h if included in the current libraries on development and only use Arduino.h. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at cleaning header file include.
Before some issue/warning was raised depending of which header was included or the order.
Ex: define in the variant.h was defined or not depending of include use.
With this PR, it is now ok.