Add variant: add support for generic F446Z(C-E)(H-J-T) and Nucleo-F446ZE - #2108
Merged
fpistm merged 2 commits intoAug 31, 2023
Merged
Add variant: add support for generic F446Z(C-E)(H-J-T) and Nucleo-F446ZE#2108fpistm merged 2 commits into
fpistm merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
CMGeldenhuys
force-pushed
the
stm32f446ze-support
branch
from
0658a0a to
4e11cf6
Compare
August 27, 2023 06:20
fpistm
self-requested a review
August 28, 2023 09:45
fpistm
requested changes
Aug 28, 2023
fpistm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Hi @CMGeldenhuys
Thanks for this PR.
Sorry for the delay, I was on vacation.
First quick review. Let's CI run to see if any errors occurs.
Sorry, something went wrong.
CMGeldenhuys
force-pushed
the
stm32f446ze-support
branch
from
4e11cf6 to
269092e
Compare
August 30, 2023 08:38
Copy link
Copy Markdown
Contributor
Author
|
Hi @fpistm, I've updated the README as requested and squashed the changes into the old commits. |
Sorry, something went wrong.
fpistm
force-pushed
the
stm32f446ze-support
branch
from
269092e to
5698042
Compare
August 30, 2023 14:07
Copy link
Copy Markdown
Member
|
Thanks @CMGeldenhuys for this PR and the nice work. |
Sorry, something went wrong.
fpistm
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the STM32F446Z(C-E)(H-J-T) variants as well as the Nucleo-F446ZE board. The code has been tested on a Nucleo-F446ZE.
Closing issues
Closes #1487 (Already marked as closed, but no support was added, from what I can see.)