FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding support for stm32c011j4m6 by alexnagelberg · Pull Request #2359 · stm32duino/Arduino_Core_STM32 · GitHub

Adding support for stm32c011j4m6 - #2359

Merged
fpistm merged 1 commit into
stm32duino:mainfrom
alexnagelberg:stm32c011j4m6
May 28, 2024
Merged

Adding support for stm32c011j4m6#2359
fpistm merged 1 commit into
stm32duino:mainfrom
alexnagelberg:stm32c011j4m6

Conversation

alexnagelberg commented May 5, 2024
edited by fpistm
Loading

Copy link
Copy Markdown
Contributor
  • Adds C011J(4-6)Mxx variants

fpistm changed the title Adding support for stm32c011j4m6 (j4/j6XX should be supported but unt… Adding support for stm32c011j4m6 May 6, 2024
fpistm added the new variant Add support of new bard label May 6, 2024
fpistm added this to the 2.8.0 milestone May 6, 2024

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @alexnagelberg
Thanks for this PR.
Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).
Plus a small update of the ldscript to be generic.
Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files

Copy link
Copy Markdown
Contributor Author

Hi @alexnagelberg

Thanks for this PR.

Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).

Plus a small update of the ldscript to be generic.

Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files

@fpistm Sure, although this ldscript was generated by cubemx, so I'm not sure how to get it to include but will play around. Just a heads up that this PR is not ready so I put it in draft, mostly as a reminder to myself to finish it.

Copy link
Copy Markdown
Contributor Author

Added remaining changes. Still in testing with my new chip.

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some minor update to avoid astyle issue.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor Author

One thing I'm concerned about with the existing code is default generic Serial is I believe pointed at the same pins which will only work for half-duplex. May want to use the same pin configuration as the bootloader uses for USART1. I've been having trouble getting it to work even with pin changes though.

fpistm commented May 13, 2024

Copy link
Copy Markdown
Member

Pins defined in the variant generic have no link with the built-in bootloader. Generic files could not be changed as they are automatically generated.

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

fpistm marked this pull request as ready for review May 13, 2024 12:22

fpistm commented May 13, 2024

Copy link
Copy Markdown
Member

@alexnagelberg If it is ok for you I will merge the PR.

Copy link
Copy Markdown
Contributor Author

@alexnagelberg If it is ok for you I will merge the PR.

@fpistm Serial doesn't appear to be setup correctly but everything else appears working. I'm okay with it being merged and staying yellow heart.

fpistm commented May 13, 2024
edited
Loading

Copy link
Copy Markdown
Member

Serial doesn't appear to be setup correctly

The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work.
What is the issue? wrong speed ? ...

fpistm commented May 27, 2024

Copy link
Copy Markdown
Member

Serial doesn't appear to be setup correctly

The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work. What is the issue? wrong speed ? ...

Looking at the package, by default Serial is mapped on USART1 Using PA0 and PA1 but they are both on the same pin. So to test you can try to redefine the RX on PC14 before calling begin()

Serial.setRx(PC14);

fpistm commented May 27, 2024

Copy link
Copy Markdown
Member

I've squash you PR and update the clock config to use LL instead of HAL. This allows to save 1K flash.

fpistm commented May 27, 2024

Copy link
Copy Markdown
Member

Codespell issue can be safely ignored (see #2379).

fpistm merged commit 91671d4 into stm32duino:main May 28, 2024
fpistm linked an issue Oct 22, 2024 that may be closed by this pull request
fpistm mentioned this pull request Oct 22, 2024
93 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

Development

Successfully merging this pull request may close these issues.

STM32C011J6M6

2 participants


Back | FazBrowse Home | New Git URL