| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Hi @alexnagelberg
Thanks for this PR.
Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).
Plus a small update of the ldscript to be generic.
Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files
Sorry, something went wrong.
@fpistm Sure, although this ldscript was generated by cubemx, so I'm not sure how to get it to include but will play around. Just a heads up that this PR is not ready so I put it in draft, mostly as a reminder to myself to finish it. |
Sorry, something went wrong.
|
Added remaining changes. Still in testing with my new chip. |
Sorry, something went wrong.
There was a problem hiding this comment.
Some minor update to avoid astyle issue.
Sorry, something went wrong.
|
One thing I'm concerned about with the existing code is default generic Serial is I believe pointed at the same pins which will only work for half-duplex. May want to use the same pin configuration as the bootloader uses for USART1. I've been having trouble getting it to work even with pin changes though. |
Sorry, something went wrong.
|
Pins defined in the variant generic have no link with the built-in bootloader. Generic files could not be changed as they are automatically generated. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
@alexnagelberg If it is ok for you I will merge the PR. |
Sorry, something went wrong.
@fpistm Serial doesn't appear to be setup correctly but everything else appears working. I'm okay with it being merged and staying yellow heart. |
Sorry, something went wrong.
The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work. |
Sorry, something went wrong.
Looking at the package, by default Serial is mapped on USART1 Using PA0 and PA1 but they are both on the same pin. So to test you can try to redefine the RX on PC14 before calling begin() Serial.setRx(PC14); |
Sorry, something went wrong.
|
I've squash you PR and update the clock config to use LL instead of HAL. This allows to save 1K flash. |
Sorry, something went wrong.
|
Codespell issue can be safely ignored (see #2379). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.