FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Generic variant C071RBTx support by thernstig · Pull Request #2556 · stm32duino/Arduino_Core_STM32 · GitHub

/ Arduino_Core_STM32 Public

feat: Generic variant C071RBTx support - #2556

Merged
fpistm merged 4 commits into
stm32duino:mainfrom
thernstig:C071RBTx
Nov 13, 2024
ConversationCommits (4)ChecksFiles changed
Merged

feat: Generic variant C071RBTx support#2556
fpistm merged 4 commits into
stm32duino:mainfrom
thernstig:C071RBTx

Conversation

thernstig commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

Fixes #2536

thernstig mentioned this pull request Nov 8, 2024
Closed

thernstig commented Nov 8, 2024

Copy link
Copy Markdown
Contributor Author

@fpistm I am not sure I got the parts right about setting the clock config. I enabled USB as the only peripheral. As you can see by #2557 I am not sure I did it right.

fpistm self-requested a review November 8, 2024 13:50
fpistm added the new variant Add support of new bard label Nov 8, 2024
fpistm added this to the 2.9.0 milestone Nov 8, 2024
fpistm requested changes Nov 8, 2024
View reviewed changes
Comment thread boards.txt
Comment thread variants/STM32C0xx/C071R(8-B)T/generic_clock.c Outdated
Comment thread variants/STM32C0xx/C071R(8-B)T/generic_clock.c Outdated
Comment thread README.md Outdated
thernstig requested a review from fpistm November 11, 2024 12:55

thernstig commented Nov 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@fpistm is this ready for merge? 🙂 I did not get a chance to test it, but you might see if it is correct or not directly with your experience as an ST employee.

feat: Generic variant C071RBTx support
e581c5c 
Fixes #2536

Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
fpistm approved these changes Nov 12, 2024
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @thernstig
I've squash and apply astyle.
LGTM

fpistm mentioned this pull request Nov 12, 2024
Open
93 tasks

thernstig commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

@fpistm I am not sure why the tests fail.

fix(i2c): no I2C2_ER_IRQn for new STM32C071x
e88ece1 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
chore(cmake): update with new board
8a8303f 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
chore(ci): update generics list to skip
a8a6903 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

fpistm commented Nov 12, 2024

Copy link
Copy Markdown
Member

@fpistm I am not sure why the tests fail.

In fact new C071xx have a second I2C while previous first C0 don't. So it was managed by the Wire library.
I've made the fix.

thernstig commented Nov 12, 2024
View reviewed changes
Comment thread CI/build/conf/cores_config.json
Comment thread CI/build/conf/cores_config_ci.json
Comment thread cmake/boards_db.cmake

thernstig commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

@fpistm not sure if I can do anything about the failing link, seems unrelated. So hope you can merge 🙂 Thanks for all the help!

fpistm merged commit 7a2786a into stm32duino:main Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fpistm fpistm approved these changes

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

STM32 core based on ST HAL
Status: Done

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

Add support for STM32C071Rx

2 participants

Back | FazBrowse Home | New Git URL