FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add support for stm32F407IGHx by hlgzhx · Pull Request #2649 · stm32duino/Arduino_Core_STM32 · GitHub

/ Arduino_Core_STM32 Public

add support for stm32F407IGHx - #2649

Merged
fpistm merged 1 commit into
stm32duino:mainfrom
hlgzhx:feature/add-f407igh
Feb 5, 2025
ConversationCommits (1)ChecksFiles changed
Merged

add support for stm32F407IGHx#2649
fpistm merged 1 commit into
stm32duino:mainfrom
hlgzhx:feature/add-f407igh

Conversation

hlgzhx commented Feb 3, 2025 •
edited by fpistm
Loading

Copy link
Copy Markdown
Contributor

Summary

add support for Generic STM32F407IGHx boards by editing boards.txt and add variants/STM32F4xx/F407I(E-G)(H-T)_F417I(E-G)(H-T)/ldscript.ld


compile test is passed,my board is in school but school is closed.if you need further test on uploading,please wait me to get back to school after Chinese new year.

im glad to fix further issues on supporting stm32f407ighx boards

Fixes #2589.
Fixes #2131.

fpistm added the new variant Add support of new bard label Feb 3, 2025
fpistm marked this pull request as draft February 3, 2025 13:57
fpistm requested changes Feb 3, 2025
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @hlgzhx
Thanks for the PR anyway, it is not complete.
see my comments.
Moreover, please reference the mcu added in the README.md and add a default SystemClock_Config in the generic_clock.c.

See the Wiki for all steps:
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Add-a-new-variant-%28board%29

Comment thread boards.txt Outdated
Comment thread variants/STM32F4xx/F407I(E-G)(H-T)_F417I(E-G)(H-T)/ldscript.ld Outdated
fpistm linked an issue Feb 4, 2025 that may be closed by this pull request
[New Variant] STM32F407IGH #2589
Closed
variant(f4): add generic F407I(E-G)(H-T) and F417I(E-G)(H-T)
d54d5f7 
Fixes stm32duino#2131.
Fixes stm32duino#2589.

Signed-off-by: Steve76427 <xcr060325@163.com>
Co-Authored-by: Frederic Pillon <frederic.pillon@st.com>
fpistm force-pushed the feature/add-f407igh branch from 16cbc1a to d54d5f7 Compare February 5, 2025 08:48
fpistm marked this pull request as ready for review February 5, 2025 08:49
fpistm approved these changes Feb 5, 2025
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @hlgzhx
I've updated the PR with all my comments.

fpistm mentioned this pull request Feb 5, 2025
Open
93 tasks
fpistm merged commit 3510e4c into stm32duino:main Feb 5, 2025

hlgzhx commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

wow really thanks for your help.^_^

fpistm commented Feb 6, 2025

Copy link
Copy Markdown
Member

welcome @hlgzhx
If you can test on your side but I'm confident it works.

hlgzhx commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

ok，these days i was just waiting to get to my boards and finish the test so i didn‘t submit further correction.I'm also sure your code will work well.xD

fpistm commented Feb 6, 2025

Copy link
Copy Markdown
Member

ok，these days i was just waiting to get to my boards and finish the test so i didn‘t submit further correction.I'm also sure your code will work well.xD

I hope :)

hlgzhx commented Feb 8, 2025

Copy link
Copy Markdown
Contributor Author

thanks for your help. i've tested it on my board,it works well.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fpistm fpistm approved these changes

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

STM32 core based on ST HAL
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Variant] STM32F407IGH [New Variant] does this lib support STM32F407IGT6?

2 participants

Back | FazBrowse Home | New Git URL