FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add HAL_DISABLE_UxARTx_IRQHANDLER build flags by Santynolo · Pull Request #2902 · stm32duino/Arduino_Core_STM32 · GitHub

/ Arduino_Core_STM32 Public

Add HAL_DISABLE_UxARTx_IRQHANDLER build flags - #2902

Open
Santynolo wants to merge 1 commit into
stm32duino:mainfrom
Santynolo:hal-irqhandler-flagdisabling
ConversationCommits (1)ChecksFiles changed
Open

Add HAL_DISABLE_UxARTx_IRQHANDLER build flags#2902
Santynolo wants to merge 1 commit into
stm32duino:mainfrom
Santynolo:hal-irqhandler-flagdisabling

Conversation

Santynolo commented Jan 24, 2026

Copy link
Copy Markdown

Summary
This PR implements build flags for disabling IRQHandlers used in the uart.c file in the SrcWrapper/src/stm32 folder allowing the user to write and use their own implementations of different USARTx_IRQHandler definitions while keeping HardwareSerial functionality in other USART/UART peripherals.

New build flags
I propose implementing the following build flags:

  • HAL_DISABLE_USART1_IRQHANDLER
  • HAL_DISABLE_USART2_IRQHANDLER
  • HAL_DISABLE_USART3_IRQHANDLER
  • HAL_DISABLE_UART4_IRQHANDLER
  • HAL_DISABLE_USART4_5_IRQHANDLER
  • HAL_DISABLE_USART4_IRQHANDLER
  • HAL_DISABLE_USART5_IRQHANDLER
  • HAL_DISABLE_USART6_IRQHANDLER
  • HAL_DISABLE_LPUART1_IRQHANDLER
  • HAL_DISABLE_UART7_IRQHANDLER
  • HAL_DISABLE_UART8_IRQHANDLER
  • HAL_DISABLE_UART9_IRQHANDLER
  • HAL_DISABLE_UART10_IRQHANDLER
  • HAL_DISABLE_USART10_IRQHANDLER
  • HAL_DISABLE_USART11_IRQHANDLER
  • HAL_DISABLE_UART12_IRQHANDLER
  • HAL_DISABLE_UART_WAKEUPCALLBACK

A build flag for each IRQHandler.
Why
This change would allow using custom implementations of for example, the USART2 and USART3 peripherals in synchronous mode (using a clock signal), while leaving the USART1 interface or others as a HardwareSerial port for printing to a serial monitor, or for use by libraries that use the standard Print class for debugging.

Here's an example of a build flag (in platformio) and a standard USART3_IRQHandler user definition (that compiles).

This code compiles (and the USART3_IRQHandler triggers correctly) with no errors (that i know of), and allows using USART1 as the Serial port and printing with no issues.
This is my first PR, please suggest improvements.
Implementation
I have implemented this by surrounding all of the IRQHandlers defined in uart.c in #ifndef [FLAG]

NOTE that this can break or cause unexpected behaviour if this build flag is defined and the user attempts to use the corresponding HardwareSerial class. Trying to use HardwareSerial on the USART2 while the build flag HAL_DISABLE_USART2_IRQHANDLER is defined will cause crashes and other behaviour i'm sure (Have not attempted). So i would suggest warning about this on the Wiki if this PR is merged.
Fixes

Fixes #2899

Santynolo commented Jan 24, 2026

Copy link
Copy Markdown
Author

I have accidentally added an extra commit (Merge branch 'stm32duino:main' into hal-irqhandler-flagdisabling) that i do not know how to remove.

fpistm commented Jan 26, 2026

Copy link
Copy Markdown
Member

I have accidentally added an extra commit (Merge branch 'stm32duino:main' into hal-irqhandler-flagdisabling) that i do not know how to remove.

Hi @Santynolo
Thanks for the PR. Will review it and study it carefully soon.
About the extra commit, simply checkout the first commit with the same branch name then do a force push. This will clear the PR.
If you want rebase on top of the main branch use git rebase command.

fpistm force-pushed the hal-irqhandler-flagdisabling branch from 3885c7e to 7a8db1e Compare January 27, 2026 08:14

fpistm commented Jan 27, 2026

Copy link
Copy Markdown
Member

I've updated your branch. Simply do a git fetch.

Santynolo commented Jan 27, 2026

Copy link
Copy Markdown
Author

Thanks.

fpistm commented Jan 27, 2026

Copy link
Copy Markdown
Member

One issue is to disable some handler managing several U(S)ART. In that case you can't use Arduino part for all impacted one.
I guess a better way would be to be able to register dedicated handler and callback then no need to disable the handler.

Santynolo commented Jan 27, 2026

Copy link
Copy Markdown
Author

That could be possible, but i think it would require a deeper integration into the Serial implementation that i'm not that familiar with, and a way to switch between calling HAL_USART_IRQHandler() or HAL_UART_IRQHandler()

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a build flag to disable specific USART IRQ handlers defined in the core

2 participants

Back | FazBrowse Home | New Git URL