FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Resolve upload issues on macOS Ventura by INOUETAICHI · Pull Request #86 · stm32duino/Arduino_Tools · GitHub

/ Arduino_Tools Public

Resolve upload issues on macOS Ventura - #86

Merged
fpistm merged 1 commit into
stm32duino:mainfrom
INOUETAICHI:patch-1
Jan 30, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Resolve upload issues on macOS Ventura#86
fpistm merged 1 commit into
stm32duino:mainfrom
INOUETAICHI:patch-1

Conversation

INOUETAICHI commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

The df -l option on macOS Ventura ignores Mass Storage Volume of STM32. If you remove the -l option it works fine.

Resolve upload issues on macOS Ventura
69a2d64 
The df -l option on macOS Ventura ignores Mass Storage Volume of STM32.
If you remove the -l option it works fine.
INOUETAICHI marked this pull request as ready for review November 14, 2022 17:36

fpistm commented Nov 14, 2022

Copy link
Copy Markdown
Member

Hi @INOUETAICHI
Thanks for this PR. Anyway I do not understand why it not works like before. '-l' is for local file system.
So I would like understand before merge.
Could you test manually the command.

fpistm self-requested a review November 15, 2022 07:42
fpistm added the waiting feedback Further information is required label Nov 15, 2022

INOUETAICHI commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

May be relevant to this discussion.
ARMmbed/DAPLink#982 (comment)

However, I don't think this change will cause any problems since there is no obstacle to get Nucleo MSC drive without using the local option anyway.

fpistm commented Nov 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

However, I don't think this change will cause any problems since there is no obstacle to get Nucleo MSC drive without using the local option anyway.

OK but as stated my main concern is to understand why '-l' does not work for you. I will test on out Mac.

Maybe a STLink firmware issue. Could you try to update your STLink Firmware using the STM32CubeProgrammer.

fpistm commented Dec 5, 2022

Copy link
Copy Markdown
Member

Our Mac will not support Ventura release.
Could you connect a board and share the result of df -HL command?

It seems Mac uses dedicated coreutils maybe "-l" option is not bundled anyway it seems strange as it is a basic feature making them incompatible with lot of scripts. That's why having the output of the above command could help to understand.

fpistm approved these changes Jan 30, 2023
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM
Should be safe.
Mac OS uses dedicated coreutils probably "-l" option is no more bundled with new OS version.

fpistm added enhancement New feature or request and removed waiting feedback Further information is required labels Jan 30, 2023
fpistm added this to the 2.2.0 milestone Jan 30, 2023
fpistm merged commit 556da4a into stm32duino:main Jan 30, 2023

INOUETAICHI commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

Thank you fpistm!

fpistm commented Jan 31, 2023

Copy link
Copy Markdown
Member

Thank you fpistm!

Welcome, anyway, I would really like having the the output of df -HL command could help to understand. 😉

fpistm mentioned this pull request Feb 20, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fpistm fpistm approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL