docs: Add some notes that Client.connect() should be called after Client.login() - #140
docs: Add some notes that Client.connect() should be called after Client.login()#140Taureon wants to merge 2 commits into
Conversation
Sorry, something went wrong.
…alled after Client.login() Signed-off-by: Taureon <45183108+Taureon@users.noreply.github.com>
Signed-off-by: Taureon <45183108+Taureon@users.noreply.github.com>
|
For a user, login() is able to return an onboarding function. I think when I looked into why this.connect(); is commented out, I concluded that that had something to do with it. |
Sorry, something went wrong.
Hm, I think it'd still be valid to have this.connect() in and make the version that switches it to returning an onboarding function a breaking change, I'm sure it'd be a breaking change anyway as some clients would inevitably break and need to be updated? The onboarding function could probably also have this.connect(), though I have no idea how it would work in this situation anyway. |
Sorry, something went wrong.
Fixes the documentation problem this guy encountered: #139
These lines can be there until the await this.connect(); line in Client.login() is not commented out.
Irrelevant but why is it commented out anyway? It looks fine to me and Client.loginBot() is already doing that so far.