fix: Refine WebSocket connection management logic - #145
Open
bretamerman wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Had a bot that was running the other day randomly die on me. Stack trace shows it failed on this line, this.send({ type: "Ping", data: +new Date() });. 2026-03-18 11:35:28.317 [error]: Client error occurred: Received network error or non-101 status code.
2026-03-18 11:35:29.775 [error]: Uncaught Exception: Sent before connected. {
"stack": "InvalidStateError: Sent before connected.\n at new DOMException (node:internal/per_context/domexception:53:5)\n at WebSocket.send (node:internal/deps/undici/undici:12680:17)\n at EventClient.send (file:///Users/.../node_modules/revolt.js/lib/events/EventClient.js:123:22)\n at Timeout._onTimeout (file:///Users/.../node_modules/revolt.js/lib/events/EventClient.js:75:22)\n at listOnTimeout (node:internal/timers:614:17)\n at processTimers (node:internal/timers:549:7)"
}
|
Sorry, something went wrong.
adds guards to the heartbeat interval to prevent a send with an invalid socket updates connection timeout to use the connection timeout option uses clearTimeout for setTimeout and clearInterval for setInterval Signed-off-by: Bret Amerman <bret.amerman@icloud.com>
bretamerman
force-pushed
the
websockets-connection-timeouts
branch
from
08d28d9 to
2d5f1a4
Compare
March 20, 2026 01:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds guards to the heartbeat interval to prevent a send with an invalid socket updates connection timeout to use the connection timeout option uses clearTimeout for setTimeout and clearInterval for setInterval