FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Normalize regex format by Pecacheu · Pull Request #188 · stoatchat/javascript-client-sdk · GitHub

/ javascript-client-sdk Public

fix: Normalize regex format - #188

Merged
Dadadah merged 2 commits into
stoatchat:mainfrom
Pecacheu:fix/regex
Aug 20, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: Normalize regex format#188
Dadadah merged 2 commits into
stoatchat:mainfrom
Pecacheu:fix/regex

Conversation

Pecacheu commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Matches the ULID regex format with what for-web uses because I'm pedantic like that and y'all need to use RegEx properly (I need to de-duplicate some of the regex that does the same thing as these strings in for-web too later)

fix: Normalize regex format
b2b3530 
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
amycatgirl approved these changes Aug 19, 2026
View reviewed changes

amycatgirl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 🐇

Dadadah commented Aug 19, 2026

Copy link
Copy Markdown
Member

These two regex tests are not the same. The original is omitting I and L, probably for ambiguity reasons.

Pecacheu commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

These two regex tests are not the same. The original is omitting I and L, probably for ambiguity reasons.

Uh oh
That means the ones in for-web are wrong then

Hmm, looks like it's missing four, in fact: I, L, O, and U. Which makes sense now that I think about it because it is base32... But there's 26 letters in the alphabet, and 10 numbers... So, four letters need to be dropped or else the math wouldn't math. :O

Thanks for noticing this lol
I think the numbers can still become \d though. And I'll refactor for-web to use the same in it's ID-checking regexes.

Dadadah reviewed Aug 20, 2026
View reviewed changes
Comment thread src/lib/regex.ts Outdated
Pecacheu force-pushed the fix/regex branch 2 times, most recently from 634bcb7 to ab0d830 Compare August 20, 2026 04:51
fix: ULID is missing some letters
591e7f4 
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Dadadah merged commit d435932 into stoatchat:main Aug 20, 2026
4 checks passed
Pecacheu mentioned this pull request Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Dadadah Dadadah left review comments
+1 more reviewer
amycatgirl amycatgirl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL