Check if include-schema argument provided and pass option to generator - #34
akera-io wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Sorry, something went wrong.
| console.error('Generating %j for the API endpoint %j', ngModuleName, apiUrl); | ||
| var result = generator.services(app, ngModuleName, apiUrl); | ||
| console.error('Generating %j for the API endpoint %j', ngModuleName, apiUrl, includeSchemas); | ||
| var result = generator.services(app, ngModuleName, apiUrl, includeSchemas); |
There was a problem hiding this comment.
@akera-io Could you please rework this line to use the new options-based API introduced in strongloop/loopback-sdk-angular#223?
Sorry, something went wrong.
|
@akera-io sorry for the delay. Could you please address my comment above and add a unit-test to verify the new option? |
Sorry, something went wrong.
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Sorry, something went wrong.
|
I am closing this pull request as abandoned. @akera-io feel free to reopen whenever you have time to address my comments above:
and also rebase the patch on top of the current master. |
Sorry, something went wrong.
That goes together with the other pull request strongloop/loopback-sdk-angular#194 done on loopback-sdk-angular about adding the option to include model definition (properties) into the generated resources, the client need to be able to use the option.