Strict frame start check -> frame.py - #34
Open
SaxonWood wants to merge 2 commits into
Open
SaxonWood wants to merge 2 commits into
SaxonWood wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
new option in frame.py -> ReceiveFrame Class -> consume Class and consume function is backward compatible. Only if new parameter "strict_start_check" is set to True, the start of frame search will be stricter as before and expect a '00' preamble before the start-token. This helps to avoid the "invalid command" errors seen with newer inverter software versions.
SaxonWood
marked this pull request as ready for review
December 20, 2025 10:52
Copy link
Copy Markdown
|
A small note from reading the current diff: the property setter assigns self._strict_start_smatch = newval (extra s), while the constructor and consume() use self._strict_start_match — so enabling the option via the property setter silently does nothing; only the constructor argument takes effect. From our field testing on a Power Storage 6.0, a boundary-tolerant variant (accepting + directly at the resync boundary) additionally avoided losing valid frames that immediately follow discarded garbage. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new option in frame.py -> ReceiveFrame Class -> consume
Class and consume function is backward compatible. Only if new parameter "strict_start_check" is set to True, the start of frame search will be stricter as before and expect a '00' preamble before the start-token. This helps to avoid the "invalid command" errors seen with newer inverter software versions.