fix(syncthing): add note about --no-console requiring Command Prompt - #957
tomasz1986 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Clarify that the `--no-console` option only works when the Command Prompt is set to be the default Windows shell. On the other hand, the option does nothing when the default shell is set to Windows Terminal. Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
|
@calmh Please don't mind a quick question, but I'm just really unsure. Should this be prefixed with "fix(syncthing)" (as is right now) or rather "fix(users/syncthing)" or maybe just "fix(users)"? |
Sorry, something went wrong.
|
Unsure, unclear if the scope adds much value anyway. We might just skip them entirely for the docs repo? |
Sorry, something went wrong.
Do you mean like in the old days, just without capitalisation? 😀 users/syncthing: add note about --no-console requiring Command Prompt |
Sorry, something went wrong.
|
He was not saying to leave out the type (fix), but the scope (where it applies). |
Sorry, something went wrong.
|
Ah, I see. I'm not really sure about that then, as most of the commits do seem to have their scope clearly stated. I personally find it useful when skimming through the commit list. In this particular case, I think it is mostly the name of the file (syncthing) that doesn't add much value. This is different with others like autostart, ignoring, etc. |
Sorry, something went wrong.
fix(syncthing): add note about --no-console requiring Command Prompt
Clarify that the --no-console option only works when the Command
Prompt is set to be the default Windows shell. On the other hand, the
option does nothing when the default shell is set to Windows Terminal.
Signed-off-by: Tomasz Wilczyński twilczynski@naver.com