fix(db): WAL friendly vacuum - #10556
Draft
bt90 wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bt90
force-pushed
the
wal_friendly_vaccum
branch
3 times, most recently
from
6e6705f to
f33e4cb
Compare
February 7, 2026 21:59
Signed-off-by: bt90 <btom1990@googlemail.com>
Copy link
Copy Markdown
Contributor
|
Good direction with splitting incremental_vacuum into bounded chunks. However, as #10559 suggests checkpoint starvation is caused by frequent readers rather than simply excess freelist growth, is there a risk of tying checkpoint attempts too closely to vacuum triggering here? Also, if WAL growth happens independently of freelist thresholds (as it seems to), should checkpoint escalation (PASSIVE -> FULL/RESTART) be driven by WAL conditions rather than vacuum conditions? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #10554
Previously, we used to perform a full incremental vacuum run as part of our periodic clean-up. This is problematic for two reasons:
This PR causes vacuum to be skipped if the number of free pages is less than 1k or 10% of the database size. If the freelist exceeds this threshold, an incremental vacuum is invoked in a loop, with a limit of 1k pages per execution. To avoid uncontrolled WAL growth, a passive checkpoint is attempted every fourth invocation. If multiple passive checkpoints fail to complete, we switch to a restart checkpoint for the next iteration.
Testing
TBD
Authorship
Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.