Update constants for systemd 258 - #157
Merged
behrmann merged 3 commits intoOct 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
update-constants.py
Dismissed
behrmann
reviewed
Oct 4, 2025
behrmann
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks! Changing the sed stuff to Python makes it a lot more readable.
Sorry, something went wrong.
Comment thread
update-constants.py
Outdated
Comment thread
update-constants.py
Outdated
Comment thread
update-constants.py
Outdated
Comment thread
update-constants.py
Outdated
Comment thread
update-constants.py
Outdated
behrmann
reviewed
Oct 4, 2025
Comment thread
src/systemd/meson.build
|
|
||
| include_dir = libsystemd_dep.get_variable(pkgconfig: 'includedir') | ||
|
|
||
| update_constants = custom_target( |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Having bashed my head against meson for a bit now, shouldn't this be a run_target instead?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Dunno. I copied from the systemd config, update-man-rules target.
Sorry, something went wrong.
$ ninja -C build update-constants -v ninja: Entering directory `build' [1/1] /home/zbyszek/src/python-systemd/update-constants.py /home/zbyszek/src/python-systemd/src/systemd/id128-constants.h /home/zbyszek/src/python-systemd/docs/id128.rst /home/zbyszek/src/python-systemd/src/systemd/id128-defines.h /usr/include/systemd/sd-messages.h Writing /home/zbyszek/src/python-systemd/src/systemd/id128-constants.h… Writing /home/zbyszek/src/python-systemd/src/systemd/id128-defines.h… Writing /home/zbyszek/src/python-systemd/docs/id128.rst… The helper is updated to do the everything in the python script. The wrapper in Makefile is dropped. It wasn't working properly anyway, and I think the version in meson is enough.
The previous commit changes the sorting algorithm, so a few lines moved up or down a bit.
keszybz
force-pushed
the
update-constants
branch
from
d8fbc3f to
1e29ed1
Compare
October 11, 2025 20:29
behrmann
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.