FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add dbclass name for Cisco Information Server by carlsonp · Pull Request #140 · tableau/document-api-python · GitHub

/ document-api-python Public

add dbclass name for Cisco Information Server - #140

Merged
graysonarts merged 1 commit into
tableau:masterfrom
carlsonp:patch-1
Feb 16, 2018
ConversationCommits (1)ChecksFiles changed
Merged

add dbclass name for Cisco Information Server#140
graysonarts merged 1 commit into
tableau:masterfrom
carlsonp:patch-1

Conversation

carlsonp commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

No description provided.

t8y8 commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

@RussTheAerialist does this require a CLA?

@carlsonp looks fine to me, just need to check on the above first.

t8y8 approved these changes Jul 21, 2017
View reviewed changes

t8y8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🚀

graysonarts commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

@t8y8 I don't know, and @benlower left for the day so I won't be able to ask until Monday.

carlsonp commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

Since it's a simple fix and I'm not quite sure what is necessary for CLA, it might be better if one of you fine folks just committed the fix?

t8y8 approved these changes Feb 15, 2018
View reviewed changes

t8y8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm gonna go ahead and call this 'trivial' and approve it.

@RussTheAerialist ?

graysonarts commented Feb 16, 2018

Copy link
Copy Markdown
Contributor

Oh yeah, let's just merge that in, that's really simple.

graysonarts merged commit 4d39126 into tableau:master Feb 16, 2018
jacalata pushed a commit that referenced this pull request Jun 4, 2021
add dbclass name for Cisco Information Server (#140)
a0be6dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
t8y8 t8y8 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL