FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#141 - Enabling Zip64 Extension to support zipfile >- 2GB. by doulam · Pull Request #144 · tableau/document-api-python · GitHub

/ document-api-python Public

#141 - Enabling Zip64 Extension to support zipfile >- 2GB. - #144

Merged
t8y8 merged 1 commit into
tableau:developmentfrom
doulam:development
Aug 14, 2017
ConversationCommits (1)ChecksFiles changed
Merged

#141 - Enabling Zip64 Extension to support zipfile >- 2GB.#144
t8y8 merged 1 commit into
tableau:developmentfrom
doulam:development

Conversation

doulam commented Aug 7, 2017

Copy link
Copy Markdown
Contributor

t8y8 commented Aug 7, 2017

Copy link
Copy Markdown
Contributor

@doulam thanks! We'll process the CLA and get this reviewed shortly!

(It seems very straight forward :) )

doulam commented Aug 14, 2017

Copy link
Copy Markdown
Contributor Author

Hi, Do you have an ETA on when this PR will be released?

t8y8 commented Aug 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@doulam our legal team was reviewing the CLA and I haven't heard back yet; I'll give them a ping

EDIT: Just heard back and it's ok from the legal end.

t8y8 approved these changes Aug 14, 2017
View reviewed changes

t8y8 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🚀

Note that Python itself made this the default in 3.4; so this will cover anyone on 2.7 or 3.3 using our library (https://bugs.python.org/issue17201)

t8y8 merged commit c7a2926 into tableau:development Aug 14, 2017
jacalata pushed a commit that referenced this pull request May 29, 2021
Enabling Zip64 Extension to support zipfile >- 2GB. (#144)
2dbe819 
Python itself made this the default in 3.4. This will cover anyone on 2.7 or 3.3 (https://bugs.python.org/issue17201)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
t8y8 t8y8 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL