FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updating development branch with publishing fixes by graysonarts · Pull Request #40 · tableau/document-api-python · GitHub

Updating development branch with publishing fixes - #40

Merged
graysonarts merged 5 commits into
tableau:developmentfrom
graysonarts:publish-script
Jun 29, 2016
Merged

Updating development branch with publishing fixes#40
graysonarts merged 5 commits into
tableau:developmentfrom
graysonarts:publish-script

Conversation

Copy link
Copy Markdown
Contributor

This was done originally on master to just make things easier, but needs to be brought into development.
This change also adds the publish.sh script used for publishing to pypi.

Comment thread publish.sh
@@ -0,0 +1,9 @@
#!/usr/bin/env bash

t8y8 Jun 29, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This won't work for a standard Windows world -- maybe that's ok but there are some cross platform options if we want to start adding build/test/doc scripts. A lot of projects use http://www.pyinvoke.org/ which is a rake-like system.

Not blocking, just a thought

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point @t8y8 though I'm hesitant to take a dependency on an external module just for making our job of pushing to pypi easier.
Eventually, I'd like to automate publishing to pypi when we create the release tag.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, we probably won't hit the inflection point of needing something like that for a while.

Changes LGTM

graysonarts merged commit c26ee64 into tableau:development Jun 29, 2016
graysonarts deleted the publish-script branch June 29, 2016 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL