Basic TWBX Support - #43
Merged
graysonarts merged 6 commits intoJun 30, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…t. I'm not sure where a lot of the zip stuff should go.
Comment thread
test/bvt.py
Outdated
| # TODO: Move the XML into external files and load them when needed | ||
|
|
||
| TABLEAU_93_WORKBOOK = '''<?xml version='1.0' encoding='utf-8' ?><workbook source-build='9.3.1 (9300.16.0510.0100)' source-platform='mac' version='9.3' xmlns:user='http://www.tableausoftware.com/xml/user'><datasources><datasource caption='xy (TestV1)' inline='true' name='sqlserver.17u3bqc16tjtxn14e2hxh19tyvpo' version='9.3'><connection authentication='sspi' class='sqlserver' dbname='TestV1' odbc-native-protocol='yes' one-time-sql='' server='mssql2012.test.tsi.lan' username=''></connection></datasource></datasources></workbook>''' # noqa | ||
| TABLEAU_93_TWB = 'test/assets/TABLEAU_93_TWB.twb' |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
You should use this pattern when accessing files in test cases, so it's always based on a specific path:
os.path.join(
os.path.dirname(__file__),
'test', 'asserts', filename
))
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yeah, that's less fragile.
It looks like it would be:
os.path.join( os.path.dirname(__file__), 'asserts', filename) )
No 'tests' directory, since bvt.py is already located in test.
Since os.path.dirname(__file__) is duplicated, how about:
`TEST_DIR = os.path.dirname(file)
TABLEAU_93_TWB = os.path.join(TEST_DIR, 'assets', 'TABLEAU_93_TWB.twb`
... etc
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- Yay no more embedded xml!
Tests pass on OS X py27 and py35
Replaces #13