FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding contributing.md first draft by graysonarts · Pull Request #48 · tableau/document-api-python · GitHub

/ document-api-python Public

Adding contributing.md first draft - #48

Merged
graysonarts merged 4 commits into
tableau:developmentfrom
graysonarts:contributing-file
Jul 11, 2016
ConversationCommits (4)ChecksFiles changed
Merged

Adding contributing.md first draft#48
graysonarts merged 4 commits into
tableau:developmentfrom
graysonarts:contributing-file

Conversation

graysonarts commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

Fixes #41
First draft of the contributing.md. Please feel free to comment on wording, improvements, etc.

benlower commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

Let's get @lbrendanl and @jdomingu to weigh in too.

I like this. Would be good to add something like "If you are considering adding a new feature, we suggest starting a conversation about it first to identify any potential design or scheduling issues before jumping in."

lbrendanl commented Jul 7, 2016

Copy link
Copy Markdown

Would it be worth just briefly mentioning that issues and feature requests are done through GH issues and all other fixes are done through PRs? I don't think it's uncommon for some to be unfamiliar with GitHub so it may be worth calling out.

t8y8 commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

Looks good to me

graysonarts commented Jul 8, 2016

Copy link
Copy Markdown
Contributor Author

@benlower I just saw your second comment about starting a conversation. I'll add something and send a new update real quick.

benlower commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

nice

t8y8 reviewed Jul 8, 2016
View reviewed changes
Comment thread contributing.md Outdated
creating a PR can be found in the [github documentation](https://help.github.com/articles/creating-a-pull-request/)

If the feature is complex or has multiple solutions that could be equally appropriate approaches, it would be helpful to file an issue to discuss the
design trade-offs of each solution before implementing, to allow us to collective arrive at the best solution, which most likely exists in the middle

t8y8 Jul 8, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

to collectively

graysonarts commented Jul 8, 2016

Copy link
Copy Markdown
Contributor Author

yeah, I english good. Thanks @t8y8, fixed

graysonarts commented Jul 11, 2016

Copy link
Copy Markdown
Contributor Author

Anymore feedback on this one? Or is it good to merge?

jdomingu commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

Ship it!

benlower commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

graysonarts merged commit d9f90f3 into tableau:development Jul 11, 2016
graysonarts deleted the contributing-file branch July 11, 2016 20:09
graysonarts mentioned this pull request Jul 11, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL