Address a refactoring concern from #54 - #55
Merged
graysonarts merged 2 commits intoJul 21, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
tableaudocumentapi/datasource.py
Outdated
| return FieldDictionary({k: v for k, v in column_objects}) | ||
| column_field_objects = self._get_column_objects() | ||
| existing_column_fields = [x.id for x in column_field_objects] | ||
| metadata_field_objects = (x for x in self._get_metadata_objects() if x.id not in existing_column_fields) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
metadata_only_field_objects -- or some hint that we have to find these a different way
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
How do I make the rocket emoji? (rocket) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
:rocket: I'll rename the variable to metadata_only_field_objects |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
🚀 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More readable by extracting a couple of methods and reorganizing the code a little.