FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a version check to provide good errors on version incompatibility by graysonarts · Pull Request #59 · tableau/document-api-python · GitHub

/ document-api-python Public

Add a version check to provide good errors on version incompatibility - #59

Merged
graysonarts merged 4 commits into
tableau:developmentfrom
graysonarts:58-fix
Jul 26, 2016
ConversationCommits (4)ChecksFiles changed
Merged

Add a version check to provide good errors on version incompatibility#59
graysonarts merged 4 commits into
tableau:developmentfrom
graysonarts:58-fix

Conversation

graysonarts commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

partial fix for #58

benlower commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

what else needs to be done to make this a 'full' fix?

graysonarts commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

I don't quite know yet. Waiting on the non-8.0 ones that are failing
On Fri, Jul 22, 2016 at 4:08 PM Ben Lower notifications@github.com wrote:

what else needs to be done to make this a 'full' fix?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFxVRKNnZdv2eDjejLMCzvfYj4ElbDVks5qYU1ggaJpZM4JTMa1
.

t8y8 commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

Working on some stats to veirfy

t8y8 commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

Counter({'8.0': 46, '8.2': 2, '8.1': 1, '9.0': 1})

One of the workbooks was 9.0, I'll send that one to @RussTheAerialist to see if it's related or not

graysonarts commented Jul 23, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @t8y8 ! I'll either get a fix done this weekend or Monday (depending on how my weekend goes)

t8y8 reviewed Jul 23, 2016
View reviewed changes
Comment thread tableaudocumentapi/xml_open.py Outdated
MIN_SUPPORTED_VERSION = Version("9.0")


class VersionNotSupportedException(Exception):

t8y8 Jul 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TableauFileVersionNotSupported or TableauVersionNotSupported?

graysonarts commented Jul 25, 2016

Copy link
Copy Markdown
Contributor Author

Btw, the last commit makes this a complete fix for #58

graysonarts reviewed Jul 25, 2016
View reviewed changes
Comment thread tableaudocumentapi/xfile.py

def find_file_in_zip(zip):
for filename in zip.namelist():
def find_file_in_zip(zip_file):

graysonarts Jul 25, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change is because zip is a built-in so we should not use that as a name of the argument.

t8y8 Jul 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's coo' w. me

t8y8 commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

🚀

benlower commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

🚀

graysonarts merged commit aa93eef into tableau:development Jul 26, 2016
graysonarts deleted the 58-fix branch July 26, 2016 02:36

graysonarts commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

This is the last fix before 0.2 is cut (unless someone speaks up). I'm going to cut the release in the morning.

graysonarts mentioned this pull request Jul 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL