FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Basic connection retargeting by t8y8 · Pull Request #65 · tableau/document-api-python · GitHub

/ document-api-python Public

Basic connection retargeting - #65

Merged
t8y8 merged 2 commits into
tableau:developmentfrom
t8y8:feature-connection-retarget
Jul 27, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Basic connection retargeting#65
t8y8 merged 2 commits into
tableau:developmentfrom
t8y8:feature-connection-retarget

Conversation

t8y8 commented Jul 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

First attempt for feedback, really simple implementation.

A tiny part of the full #34

  • Following the same setters as elsewhere
  • I copied the good dbclasses from a cpp file, and removed the ones I didn't think are out of beta yet
  • Tests

graysonarts reviewed Jul 26, 2016
View reviewed changes
Comment thread tableaudocumentapi/connection.py Outdated
#
###############################################################################

KNOWN_DB_CLASSES = ('msaccess',

graysonarts Jul 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh ew. I mean, I understand why, but maybe move it into it's own file.

t8y8 Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hahahaha. But getting them all lined up took the most time for this PR! (And writing the regex to extract them)

constants.py? Or something more specific?

graysonarts Jul 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

well, if we call it something like dbclass and bundle the IsValidDbClass function in the same file, I think that's be good, because then you'd never really expose the constant, you'd always just use the IsValid* function

graysonarts commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

🚀

t8y8 merged commit 44ca620 into tableau:development Jul 27, 2016
t8y8 deleted the feature-connection-retarget branch July 27, 2016 03:20
graysonarts modified the milestone: 2016.08 release Aug 29, 2016
t8y8 mentioned this pull request Sep 22, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2016.08 release (v0.3)

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL