#72 Add description to the field object - #73
Merged
graysonarts merged 2 commits intoAug 23, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Pull in the description if it exists on a `<column>` tag.
This change returns the entire `<desc>` tag including all subtags.
e.g.:
```
<desc>
<formatted-text>
<run>Total number of people in a country</run>
</formatted-text>
</desc>
```
Comment thread
test/test_datasource.py
Outdated
| def test_datasource_field_description(self): | ||
| actual = self.ds.fields['[a]'].description | ||
| self.assertIsNotNone(actual) | ||
| contains_string = actual.index(u'muted gray') |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
contains_string = u'muted gray' in actual self.assertTrue(contains_string)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
🚀 just a minor nit |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #72 (only implements reading)
Pull in the description if it exists on a <column> tag.
This change returns the entire <desc> tag including all subtags.
e.g.:
<desc> <formatted-text> <run>Total number of people in a country</run> </formatted-text> </desc>