FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Scrub some strings in the test files by t8y8 · Pull Request #82 · tableau/document-api-python · GitHub

/ document-api-python Public

Scrub some strings in the test files - #82

Merged
t8y8 merged 2 commits into
tableau:developmentfrom
t8y8:79-bugfix-cleanup-test-strings
Sep 13, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Scrub some strings in the test files#82
t8y8 merged 2 commits into
tableau:developmentfrom
t8y8:79-bugfix-cleanup-test-strings

Conversation

t8y8 commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

Removing the 'tsi.lan' suffix that's internal to Tableau and not really relevant for general usage

t8y8 changed the base branch from master to development September 9, 2016 17:50
t8y8 mentioned this pull request Sep 11, 2016
Closed

t8y8 commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

Ping (I'm just OCD and want to clear my open PRs)

/cc @RussTheAerialist

graysonarts commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

I'm oof today because my dog is having a surgery. I'll take a look tomorrow
On Tue, Sep 13, 2016 at 13:42 Tyler Doyle notifications@github.com wrote:

Ping (I'm just OCD and want to clear my open PRs)

/cc @RussTheAerialist https://github.com/RussTheAerialist

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFxVdaevg5VdVzAJIdBsA7SX5UqyP3fks5qpwrLgaJpZM4J5SI0
.

LGraber reviewed Sep 13, 2016
View reviewed changes
Comment thread test/bvt.py
self.assertIsInstance(connections, list)
self.assertIsInstance(connections[0], Connection)
self.assertEqual(connections[0].dbname, 'testv1')
self.assertEqual(connections[0].dbname, 'TestV1')

LGraber Sep 13, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How did this pass before?

t8y8 Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The test asset had it lowercase too, my OCD said 'no' and I updated it to match the others

LGraber Sep 13, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That is OOOCCCDDD

LGraber commented Sep 13, 2016

Copy link
Copy Markdown

🚀

t8y8 merged commit 5f91af0 into tableau:development Sep 13, 2016
t8y8 deleted the 79-bugfix-cleanup-test-strings branch September 13, 2016 21:00
graysonarts pushed a commit that referenced this pull request Oct 7, 2016
Scrub some strings in the test files (#82)
9974238 
* Scrub some strings in the test file so they don't include internal references
* Updated some of the assets to be consistent in casing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL