FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

⬆️ Allow more recent version of packaging by r-richmond · Pull Request #1196 · tableau/server-client-python · GitHub

/ server-client-python Public

⬆️ Allow more recent version of packaging - #1196

Merged
jacalata merged 1 commit into
tableau:masterfrom
r-richmond:patch-1
Feb 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

⬆️ Allow more recent version of packaging#1196
jacalata merged 1 commit into
tableau:masterfrom
r-richmond:patch-1

Conversation

r-richmond commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

Why make change

The current specification conflicts with new versions of black
https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/pyproject.toml#L68

What do the new versions of packaging do

https://github.com/pypa/packaging/releases/tag/22.0
of note

  1. Removes support for python 3.6 (which this package doesn't support already)
  2. Adds support for python 3.11 (Which this isn't marked as supporting yet but probably should at some point)

salesforce-cla Bot commented Feb 19, 2023

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @r-richmond to sign the Salesforce.com Contributor License Agreement.

r-richmond commented Feb 19, 2023

Copy link
Copy Markdown
Contributor Author

CLA signed previously as noted here

jacalata commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

hm, looks like that brings in some changes from black as well. Can you run black to get the code back into a valid state? It looks like the vast majority of changes are this one:
Remove trailing newlines after code block open (psf/black#3035) (22.6.0)

Also, could you bump the named version to 22.0, for clarity?

r-richmond commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

Addressed both black run & bumping minimum version as requested (also added comment for more clarity)

jacalata merged commit ccdd790 into tableau:master Feb 21, 2023
r-richmond deleted the patch-1 branch February 21, 2023 00:35

r-richmond commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

@jacalata do you have a rough estimate for when the next version will go out?

jacalata mentioned this pull request Mar 9, 2023
Merged
vchavatapalli pushed a commit to vchavatapalli/server-client-python that referenced this pull request May 5, 2026
⬆️ Allow more recent version of packaging (tableau#1196)
07da33a 
re-format to match new black standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jacalata jacalata approved these changes

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL