chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version by jacalata · Pull Request #1839 · tableau/server-client-python · GitHub

Motivation

requires-python is >=3.10. Concatenate, ParamSpec, and overload
have all been in stdlib typing since 3.10 or earlier, so the imports
from typing_extensions are no-op indirection. Same story for the Black
target-version list: py39 is below the supported minimum and py314
is already in the CI matrix.

Behavior change

None. Same symbols resolve to the same objects; mypy, pytest, and
black --check all clean.

Self stays on typing_extensions since stdlib typing.Self is 3.11+
and we still support 3.10. A separate followup tracks the broader
3.10-EOL cleanup (Self, tomli fallback).

Test plan

mypy clean
pytest clean
black --check clean under the pinned Black version

🤖 Generated with Claude Code

…typing These three names live in stdlib `typing` since Python 3.10, which is the repo's supported minimum (`requires-python = ">=3.10"`). Only `Self` still requires `typing_extensions` for 3.10 users, so keep that import in place until 3.10 support drops. Also drop `py39` from Black's `target-version` array and add `py314` -- py39 is below the supported minimum, py314 is already in the CI test matrix. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Report

File	Stmts	Miss	Cover	Missing
tableauserverclient
__init__.py	5	0	100%
config.py	15	0	100%
datetime_helpers.py	25	1	1	96%
exponential_backoff.py	20	0	100%
filesys_helpers.py	31	0	100%
namespace.py	26	3	3	88%
tableauserverclient/bin
__init__.py	2	0	100%
_version.py	358	212	212	41%
tableauserverclient/helpers
__init__.py	1	0	100%
logging.py	2	0	100%
strings.py	31	1	1	97%
tableauserverclient/models
__init__.py	46	0	100%
collection_item.py	41	7	7	83%
column_item.py	55	32	32	42%
connection_credentials.py	35	11	11	69%
connection_item.py	94	14	14	85%
custom_view_item.py	144	21	21	85%
data_acceleration_report_item.py	54	1	1	98%
data_alert_item.py	158	4	4	97%
data_freshness_policy_item.py	155	15	15	90%
database_item.py	207	36	36	83%
datasource_item.py	300	12	12	96%
dqw_item.py	104	5	5	95%
exceptions.py	4	0	100%
extensions_item.py	132	4	4	97%
extract_item.py	44	4	4	91%
favorites_item.py	69	8	8	88%
fileupload_item.py	19	0	100%
flow_item.py	149	10	10	93%
flow_run_item.py	71	0	100%
group_item.py	89	6	6	93%
groupset_item.py	49	7	7	86%
interval_item.py	182	32	32	82%
job_item.py	192	10	10	95%
linked_tasks_item.py	79	1	1	99%
location_item.py	29	2	2	93%
metric_item.py	129	13	13	90%
oidc_item.py	63	3	3	95%
pagination_item.py	34	1	1	97%
permissions_item.py	111	12	12	89%
project_item.py	207	31	31	85%
property_decorators.py	100	18	18	82%
reference_item.py	26	2	2	92%
revision_item.py	59	1	1	98%
schedule_item.py	209	6	6	97%
server_info_item.py	37	7	7	81%
site_item.py	636	13	13	98%
subscription_item.py	101	2	2	98%
table_item.py	119	18	18	85%
tableau_auth.py	61	25	25	59%
tableau_types.py	27	1	1	96%
tag_item.py	15	0	100%
target.py	6	0	100%
task_item.py	56	2	2	96%
user_item.py	323	16	16	95%
view_item.py	220	16	16	93%
virtual_connection_item.py	64	8	8	88%
webhook_item.py	69	1	1	99%
workbook_item.py	362	16	16	96%
tableauserverclient/server
__init__.py	9	0	100%
exceptions.py	4	0	100%
filter.py	29	1	1	97%
pager.py	33	1	1	97%
query.py	143	15	15	90%
request_factory.py	1333	195	195	85%
request_options.py	386	5	5	99%
server.py	188	23	23	88%
sort.py	6	0	100%
tableauserverclient/server/endpoint
__init__.py	35	0	100%
auth_endpoint.py	73	10	10	86%
custom_views_endpoint.py	152	12	12	92%
data_acceleration_report_endpoint.py	21	0	100%
data_alert_endpoint.py	94	23	23	76%
databases_endpoint.py	111	30	30	73%
datasources_endpoint.py	323	33	33	90%
default_permissions_endpoint.py	44	3	3	93%
dqw_endpoint.py	45	16	16	64%
endpoint.py	258	24	24	91%
exceptions.py	79	6	6	92%
extensions_endpoint.py	31	0	100%
favorites_endpoint.py	94	22	22	77%
fileuploads_endpoint.py	51	0	100%
flow_runs_endpoint.py	62	9	9	85%
flow_task_endpoint.py	21	2	2	90%
flows_endpoint.py	198	53	53	73%
groups_endpoint.py	126	9	9	93%
groupsets_endpoint.py	72	7	7	90%
jobs_endpoint.py	68	9	9	87%
linked_tasks_endpoint.py	37	0	100%
metadata_endpoint.py	88	14	14	84%
metrics_endpoint.py	55	6	6	89%
oidc_endpoint.py	42	1	1	98%
permissions_endpoint.py	44	3	3	93%
projects_endpoint.py	178	24	24	87%
resource_tagger.py	127	35	35	72%
schedules_endpoint.py	119	11	11	91%
server_info_endpoint.py	36	10	10	72%
sites_endpoint.py	130	27	27	79%
subscriptions_endpoint.py	56	14	14	75%
tables_endpoint.py	110	36	36	67%
tasks_endpoint.py	63	6	6	90%
users_endpoint.py	183	8	8	96%
views_endpoint.py	150	9	9	94%
virtual_connections_endpoint.py	113	10	10	91%
webhooks_endpoint.py	54	9	9	83%
workbooks_endpoint.py	338	22	22	93%
TOTAL	12063	1424	88%

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates typing imports to rely more on the stdlib typing module and adjusts Black’s configured target Python versions.

Changes:

Replace typing_extensions usage with stdlib typing for ParamSpec/Concatenate where applicable
Split typing imports in jobs_endpoint.py (overload from typing, Self from typing_extensions)
Update Black target-version by dropping py39 and adding py314

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tableauserverclient/server/request_factory.py	Switch ParamSpec/Concatenate imports to stdlib typing
tableauserverclient/server/endpoint/jobs_endpoint.py	Move overload to stdlib typing while keeping Self on typing_extensions
tableauserverclient/server/endpoint/endpoint.py	Switch ParamSpec/Concatenate imports to stdlib typing
pyproject.toml	Update Black target-version list (drop 3.9, add 3.14)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…lib-quickwins # Conflicts: # tableauserverclient/server/endpoint/endpoint.py

jacalata requested a lite review from Copilot August 6, 2026 21:22

jacalata enabled auto-merge (squash) August 6, 2026 21:23

Copilot AI reviewed Aug 6, 2026

View reviewed changes

Comment thread tableauserverclient/server/request_factory.py

Comment thread tableauserverclient/server/endpoint/endpoint.py

Merge remote-tracking branch 'origin/development' into jac/typing-std…

4c17767

…lib-quickwins # Conflicts: # tableauserverclient/server/endpoint/endpoint.py

chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version by jacalata · Pull Request #1839 · tableau/server-client-python · GitHub

Uh oh!

chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version - #1839

chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version#1839
jacalata wants to merge 2 commits into
developmentfrom
jac/typing-stdlib-quickwins

jacalata commented Jul 29, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version by jacalata · Pull Request #1839 · tableau/server-client-python · GitHub

Uh oh!

chore: use stdlib typing for Concatenate/ParamSpec/overload; align Black target-version - #1839

Conversation

jacalata commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Behavior change

Test plan

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jacalata commented Jul 29, 2026 •
edited
Loading

github-actions Bot commented Jul 29, 2026 •
edited
Loading