fix(ui): show full MCP error messages without truncation - #2695
Merged
tusharmath merged 1 commit intoMar 25, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tusharmath
force-pushed
the
mcp-failure-log
branch
from
0630d26 to
6dccf61
Compare
March 25, 2026 19:27
tusharmath
enabled auto-merge (squash)
March 25, 2026 19:28
Comment thread
crates/forge_main/src/ui.rs
| // Show failed MCP servers | ||
| if !porcelain && !all_tools.mcp.get_failures().is_empty() { | ||
| self.writeln("MCP FAILURES\n".dimmed().bold())?; | ||
| for (_, error) in all_tools.mcp.get_failures().iter() { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Critical bug: The server name is discarded (using _), so users won't know which MCP server failed. The original code showed [✗] {server_name} - {error}. Without the server name, it's impossible to identify which server is failing, especially when multiple servers fail.
// Fix: Include the server name in the output
for (server_name, error) in all_tools.mcp.get_failures().iter() {
let error_msg = format!("{}: {}", server_name, error);
self.writeln(style(error_msg).red())?;
}Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix mcp list to display full MCP server error messages without truncation, shown in red after the server list.
Context
Previously, MCP failure messages were truncated to 80 characters with a trailing ..., making it impossible to read the full error — especially for multi-line errors like connection stack traces. This made diagnosing why an MCP server failed to initialize unnecessarily difficult.
Changes
Testing