Fix "JoinHandle polled after completion" panics caused by background tasks spawned during forge info racing with process exit.
Context
When running forge info, the handler was calling on_new() to initialize the model/agent state. However, on_new() also internally invokes hydrate_caches(), which spawns fire-and-forget background tasks. Because forge info exits quickly after printing output, these background tasks would still be running (or just completing) as the process terminated, triggering JoinHandle polled after completion panics in the async runtime.
The info command only needs agent/provider/model resolution — it has no use for the cache hydration side effects.
Changes
Replaced on_new() call with init_state(false) in the TopLevelCommand::Info handler
init_state(false) performs only the necessary state initialization without spawning background cache hydration tasks
Testing
# Run the info command and verify no panics occur
cargo run -- info
# Run with a specific conversation ID if applicable
cargo run -- info --conversation-id <id># Run the test suite for forge_main
cargo insta test --accept -p forge_main
Links
Related: background task lifecycle management in UI::on_new() / UI::hydrate_caches()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix "JoinHandle polled after completion" panics caused by background tasks spawned during forge info racing with process exit.
Context
When running forge info, the handler was calling on_new() to initialize the model/agent state. However, on_new() also internally invokes hydrate_caches(), which spawns fire-and-forget background tasks. Because forge info exits quickly after printing output, these background tasks would still be running (or just completing) as the process terminated, triggering JoinHandle polled after completion panics in the async runtime.
The info command only needs agent/provider/model resolution — it has no use for the cache hydration side effects.
Changes
Testing
Links