| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
read_range_utf8 used the infer-based ForgeFS::is_binary (MIME sniff, 8192 bytes, assumes text when type is unknown) while fs_search and all other callers used the BOM + zero-byte detector in binary_detection.rs. The same file could be skipped as binary by search but read as text by read_range. Route read_range_utf8 through the same is_binary(path) detector and remove the now-unused infer-based implementation and its dependency. Fixes tailcallhq#3633
Sorry, something went wrong.
|
Action required: PR inactive for 5 days. |
Sorry, something went wrong.
|
The fix is complete and the branch is up to date. This PR has been open for 5 days awaiting review, happy to rebase or adjust if anything needs changing. |
Sorry, something went wrong.
|
Action required: PR inactive for 5 days. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
read_range_utf8 used the infer-based ForgeFS::is_binary (MIME sniff over 8192 bytes, assumes text when the type is unknown), while fs_search, fs_write, plan_create, and image_read all used the BOM + zero-byte detector in binary_detection.rs. A file with a stray 0x00 in the first 512 bytes was skipped as binary by search but read as text by read_range_utf8.
This PR routes read_range_utf8 through the same is_binary(path) detector used by every other caller, and removes the now-unused infer-based implementation, its tests, and the infer dependency.
Files changed:
Fixes #3633
Verification