FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[DO NOT MERGE] error-boundary example by taneba · Pull Request #336 · taneba/fullstack-graphql-app · GitHub

[DO NOT MERGE] error-boundary example - #336

Open
taneba wants to merge 6 commits into
mainfrom
error-boundary
Open

[DO NOT MERGE] error-boundary example#336
taneba wants to merge 6 commits into
mainfrom
error-boundary

Conversation

taneba commented Apr 6, 2022
edited
Loading

Copy link
Copy Markdown
Owner

This is an implementation example of ErrorBoundary with Suspense.
IMO using ErrorBoundary with Suspense doesn't make sense because

  • Component inside of the ErrorBoundary and Suspense should know the parent component's implementation, which is really bad design.
  • During development, we'll see a lot of red errors on the browser or console, which is not good DX.

related #334

Base automatically changed from core/react-18 to main May 12, 2022 17:17
taneba added the pending label May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL