fix(ci): drop private @taskade/eslint-plugin so the public repo installs everywhere - #20
Closed
johnxie wants to merge 1 commit into
Closed
fix(ci): drop private @taskade/eslint-plugin so the public repo installs everywhere#20johnxie wants to merge 1 commit into
johnxie wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…lls everywhere The repo listed @taskade/eslint-plugin (a PRIVATE GitHub Packages package) in `dependencies`, and .eslintrc.json extended `plugin:@taskade/base` from it. So `yarn install --frozen-lockfile` returned 401 Unauthorized for anyone without taskade-org package access — every CI run (master + all PRs) was red, and no external contributor could install or build this PUBLIC integration kit. The plugin was lint-only and CI never even ran lint, so it was pure breakage. - Remove the private dependency; regenerate yarn.lock. - Replace .eslintrc.json with a self-contained PUBLIC config (eslint + @typescript-eslint, lenient on the existing require()/any/@ts-ignore usage). - Add a `lint` script and run it in CI — now that linting is public and the code passes, CI actually enforces it. Verified locally: yarn install / yarn lint / yarn build / yarn test (4/4) all green. Unblocks #19 and every future contributor.
johnxie
added a commit
that referenced
this pull request
Jul 1, 2026
…tions (PR #20) TRIGGERS (public webhook API, live since v6.188): new_comment, task_assigned, new_project, project_assigned, project_joined — one factory over POST /api/v2/subscribeWebhook|unsubscribeWebhook with exact server packet shapes. Legacy task_due untouched. ACTIONS: AI-agent lifecycle (create/generate/update, add knowledge, publish), project ops (complete/restore, copy, share link), task extras (set date, assign, note, custom field), and Trigger Taskade Automation (POST to a flow's inbound webhook URL — Taskade's documented integration pattern). n8n: TaskadeTrigger node — the package's first trigger, 6 events via the public subscription lifecycle; robust delete() clears local hook state even when the server hook is already gone. Pre-PR review applied 8 fixes: implicit-now date guard, share-link viewUrl mapping, custom-field label path (data.displayName), trigger delete resilience, automation-webhook failure surfacing, Infinity coercion guard, assignee empty-string filter, conditional-field pre-flight errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why CI is red on every branch (incl. master)
package.json listed @taskade/eslint-plugin (a private GitHub Packages package) in dependencies, and .eslintrc.json extended plugin:@taskade/base from it. So yarn install --frozen-lockfile returns 401 Unauthorized for anyone without taskade-org package access:
And the plugin was lint-only while CI only ran build+test (never lint) — so it was pure breakage for zero benefit.
Fix
Verified locally
yarn install · yarn lint · yarn build · yarn test (4/4) all green. This PR's own CI run will be the first green one in the repo.
Unblocks #19 and every future contributor.
🤖 Generated with Claude Code