No longer test for C++11. - #798
Open
bangerth wants to merge 1 commit into
Open
bangerth wants to merge 1 commit into
bangerth wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@bangerth thank you for the pull request! |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In looking at dealii/dealii#19188, I found a place where the current code base still checks whether the C++ standard is at least C++11. That's no longer necessary because Taskflow requires C++20 anyway.
I also looked at the other part of the #if here, testing for whether defined(UINTPTR_MAX) exists. From C++11 to C++26, the standard defines std::uintptr_t as an optional type. So it's not guaranteed that it always exists, and using defined(UINTPTR_MAX) is still necessary.