cudaGraphBase: constrain the variadic ctor on Creator being invocable - #804
Open
Gooh456 wants to merge 1 commit into
Open
Gooh456 wants to merge 1 commit into
Gooh456 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Kyue <164024549+Gooh456@users.noreply.github.com>
Copy link
Copy Markdown
Author
|
looks good, will review properly in a bit |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753. cudaGraphBase(ArgsT&&...) forwards straight to Creator{}(args...) with no constraint, so anything that probes it via std::constructible_from/if constexpr gets a hard error from inside the constructor body instead of SFINAE'ing away cleanly. Added requires std::invocable<Creator, ArgsT...> — matches the fix suggested in the issue, <concepts> is already available transitively through traits.hpp so nothing new to include.
I don't have a CUDA toolchain here to compile-verify this against the reporter's exact if constexpr(std::constructible_from<...>) repro — flagging that so it gets a real build check in CI/review rather than assuming it's clean.